[CELEBORN-1712] Bump Netty version from 4.1.109.Final to 4.1.115.Final #2903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteNicholas
force-pushed
the
CELEBORN-1712
branch
from
bc289b8
to
5da5aed
Compare
turboFei
approved these changes
Nov 12, 2024
|
LGTM overall. But are there any tests to ensure this won't introduce any performance change? |
@FMX, IMO, there is no any performance test for bumping netty version. According to release notes, there are some bugfixes in these versions. BTW, do you have any suggestion to verify performance change introduction? |
SteNicholas
changed the title
SteNicholas
force-pushed
the
CELEBORN-1712
branch
from
5da5aed
to
a827cd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Bump Netty version from 4.1.109.Final to 4.1.115.Final.
Why are the changes needed?
The Netty 4.1.115.Final version has been released, which netty version is 4.1.109.Final at present. The changes between 4.1.110.Final and 4.1.115.Final is as follows:
Bump apache/spark#46945.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI.